Saving with the emulation paused, freezes the emulation in current master


Views: 6,849,004	Homepage \| Main \| Rules/FAQ \| Memberlist \| Active users \| Last posts \| Calendar \| Stats \| Online users \| Search	04-18-24 04:02 PM
Guest:

0 users reading Saving with the emulation paused, freezes the emulation in current master | 1 bot

Main - General - Saving with the emulation paused, freezes the emulation in current master

Hide post layouts | New reply

Ricky

Posted on 07-31-20 01:52 AM

Link | #2139

Newcomer
Normal user

Level: 5

Posts: 1/5
EXP: 411
Next: 118

Since: 07-31-20

Last post: 1312 days ago
Last view: 849 days ago

I was planning to open a Github issue, but i was not sure if it was a good idea as the error occurs in master an not on the release version, so i thought it was better to write it here.
Basically in current master (i downloaded the compiled version in Actions on Github), if you make a savestate while the emulation is paused, the game frozes, you can resume it but nothing happens and the fps count in the window title doesn't appears anymore, you have to stop the emulation and open the game again, you can load the savestate and continue the emulation.
I tested it in the current release (0.8.3) and it works fine (also tested others games with the same result).

Arisotura

Posted on 07-31-20 01:54 AM

Link | #2140

Big fire melon
magical melon girl

Level: 56

Posts: 568/884
EXP: 1334648
Next: 63528

Since: 03-28-17
From: France

Last post: 7 hours ago
Last view: 7 hours ago

well, good catch, I'll look into it

____________________
Kuribo64

Ricky

Posted on 07-31-20 02:07 AM (rev. 2 of 07-31-20 02:08 AM)

Link | #2141

Newcomer
Normal user

Level: 5

Posts: 2/5
EXP: 411
Next: 118

Since: 07-31-20

Last post: 1312 days ago
Last view: 849 days ago

Worth mentioning that apparently also happens when loading savestates and the emulation is paused

Arisotura

Posted on 07-31-20 02:17 AM

Link | #2142

Big fire melon
magical melon girl

Level: 56

Posts: 569/884
EXP: 1334648
Next: 63528

Since: 03-28-17
From: France

Last post: 7 hours ago
Last view: 7 hours ago

it's weird because according to the code that shouldn't happen

____________________
Kuribo64

Ricky

Posted on 07-31-20 02:43 AM (rev. 3 of 07-31-20 02:45 AM)

Link | #2143

Newcomer
Normal user

Level: 5

Posts: 3/5
EXP: 411
Next: 118

Since: 07-31-20

Last post: 1312 days ago
Last view: 849 days ago

I dont really understand that much the code, but could be calling the function emuPause() twice be the cause? I was thinking in this part, https://github.com/Arisotura/melonDS/blob/dff14ca80ada883870131c7ff17d85866254ccc0/src/frontend/qt_sdl/main.cpp#L1488 with twice i mean the time the emulation is paused and when the savestate is saved or loaded.
That would set PrevEmuStatus = 2 and EmuRunning = 2 if i am not wrong, dont really want to write nonsense things.

Arisotura

Posted on 07-31-20 02:51 AM

Link | #2144

Big fire melon
magical melon girl

Level: 56

Posts: 570/884
EXP: 1334648
Next: 63528

Since: 03-28-17
From: France

Last post: 7 hours ago
Last view: 7 hours ago

nah, that's fine; the point is to make sure the emu thread is paused before loading or saving a state, so we don't enter some race condition fucking things up

I'll look deeper into it, anyway

____________________
Kuribo64

Arisotura

Posted on 07-31-20 07:51 PM

Link | #2145

Big fire melon
magical melon girl

Level: 56

Posts: 571/884
EXP: 1334648
Next: 63528

Since: 03-28-17
From: France

Last post: 7 hours ago
Last view: 7 hours ago

this bug should be fixed now

____________________
Kuribo64

Ricky

Posted on 07-31-20 09:40 PM

Link | #2146

Newcomer
Normal user

Level: 5

Posts: 4/5
EXP: 411
Next: 118

Since: 07-31-20

Last post: 1312 days ago
Last view: 849 days ago

Yes it works fine now, thanks!

Main - General - Saving with the emulation paused, freezes the emulation in current master

Hide post layouts | New reply

Page rendered in 0.037 seconds. (2048KB of memory used)
MySQL - queries: 29, rows: 93/93, time: 0.020 seconds.
[powered by Acmlm]