Views: 6,854,840 | Homepage | Main | Rules/FAQ | Memberlist | Active users | Last posts | Calendar | Stats | Online users | Search | 04-19-24 04:03 AM |
Guest: |
0 users reading Saving with the emulation paused, freezes the emulation in current master | 1 bot |
Main - General - Saving with the emulation paused, freezes the emulation in current master | Hide post layouts | New reply |
Ricky |
| ||
Newcomer Normal user Level: 5 Posts: 1/5 EXP: 412 Next: 117 Since: 07-31-20 Last post: 1313 days ago Last view: 850 days ago |
I was planning to open a Github issue, but i was not sure if it was a good idea as the error occurs in master an not on the release version, so i thought it was better to write it here.
Basically in current master (i downloaded the compiled version in Actions on Github), if you make a savestate while the emulation is paused, the game frozes, you can resume it but nothing happens and the fps count in the window title doesn't appears anymore, you have to stop the emulation and open the game again, you can load the savestate and continue the emulation. I tested it in the current release (0.8.3) and it works fine (also tested others games with the same result). |
Arisotura |
| ||
Big fire melon magical melon girl Level: 56 Posts: 568/884 EXP: 1334778 Next: 63398 Since: 03-28-17 From: France Last post: 19 hours ago Last view: 5 hours ago |
Ricky |
| ||
Newcomer Normal user Level: 5 Posts: 2/5 EXP: 412 Next: 117 Since: 07-31-20 Last post: 1313 days ago Last view: 850 days ago |
Worth mentioning that apparently also happens when loading savestates and the emulation is paused |
Arisotura |
| ||
Big fire melon magical melon girl Level: 56 Posts: 569/884 EXP: 1334778 Next: 63398 Since: 03-28-17 From: France Last post: 19 hours ago Last view: 5 hours ago |
Ricky |
| ||
Newcomer Normal user Level: 5 Posts: 3/5 EXP: 412 Next: 117 Since: 07-31-20 Last post: 1313 days ago Last view: 850 days ago |
I dont really understand that much the code, but could be calling the function emuPause() twice be the cause? I was thinking in this part, https://github.com/Arisotura/melonDS/blob/dff14ca80ada883870131c7ff17d85866254ccc0/src/frontend/qt_sdl/main.cpp#L1488 with twice i mean the time the emulation is paused and when the savestate is saved or loaded.
That would set PrevEmuStatus = 2 and EmuRunning = 2 if i am not wrong, dont really want to write nonsense things. |
Arisotura |
| ||
Big fire melon magical melon girl Level: 56 Posts: 570/884 EXP: 1334778 Next: 63398 Since: 03-28-17 From: France Last post: 19 hours ago Last view: 5 hours ago |
nah, that's fine; the point is to make sure the emu thread is paused before loading or saving a state, so we don't enter some race condition fucking things up
I'll look deeper into it, anyway ____________________ Kuribo64 |
Arisotura |
| ||
Big fire melon magical melon girl Level: 56 Posts: 571/884 EXP: 1334778 Next: 63398 Since: 03-28-17 From: France Last post: 19 hours ago Last view: 5 hours ago |
Ricky |
| ||
Newcomer Normal user Level: 5 Posts: 4/5 EXP: 412 Next: 117 Since: 07-31-20 Last post: 1313 days ago Last view: 850 days ago |
Yes it works fine now, thanks! |
Main - General - Saving with the emulation paused, freezes the emulation in current master | Hide post layouts | New reply |
Page rendered in 0.027 seconds. (2048KB of memory used) MySQL - queries: 29, rows: 92/92, time: 0.014 seconds. Acmlmboard 2.064 (2018-07-20) © 2005-2008 Acmlm, Xkeeper, blackhole89 et al. |