Views: 996,646 Homepage | Main | Rules/FAQ | Memberlist | Active users | Last posts | Calendar | Stats | Online users | Search 09-25-20 07:08 PM
Guest:

0 users reading Saving with the emulation paused, freezes the emulation in current master | 1 bot

Main - General - Saving with the emulation paused, freezes the emulation in current master New reply


Ricky
Posted on 07-30-20 09:52 PM Link | #2139
I was planning to open a Github issue, but i was not sure if it was a good idea as the error occurs in master an not on the release version, so i thought it was better to write it here.
Basically in current master (i downloaded the compiled version in Actions on Github), if you make a savestate while the emulation is paused, the game frozes, you can resume it but nothing happens and the fps count in the window title doesn't appears anymore, you have to stop the emulation and open the game again, you can load the savestate and continue the emulation.
I tested it in the current release (0.8.3) and it works fine (also tested others games with the same result).

Arisotura
Posted on 07-30-20 09:54 PM Link | #2140
well, good catch, I'll look into it

____________________
Kuribo64

Ricky
Posted on 07-30-20 10:07 PM (rev. 2 of 07-30-20 10:08 PM) Link | #2141
Worth mentioning that apparently also happens when loading savestates and the emulation is paused

Arisotura
Posted on 07-30-20 10:17 PM Link | #2142
it's weird because according to the code that shouldn't happen

____________________
Kuribo64

Ricky
Posted on 07-30-20 10:43 PM (rev. 3 of 07-30-20 10:45 PM) Link | #2143
I dont really understand that much the code, but could be calling the function emuPause() twice be the cause? I was thinking in this part, https://github.com/Arisotura/melonDS/blob/dff14ca80ada883870131c7ff17d85866254ccc0/src/frontend/qt_sdl/main.cpp#L1488 with twice i mean the time the emulation is paused and when the savestate is saved or loaded.
That would set PrevEmuStatus = 2 and EmuRunning = 2 if i am not wrong, dont really want to write nonsense things.

Arisotura
Posted on 07-30-20 10:51 PM Link | #2144
nah, that's fine; the point is to make sure the emu thread is paused before loading or saving a state, so we don't enter some race condition fucking things up

I'll look deeper into it, anyway

____________________
Kuribo64

Arisotura
Posted on 07-31-20 03:51 PM Link | #2145
this bug should be fixed now

____________________
Kuribo64

Ricky
Posted on 07-31-20 05:40 PM Link | #2146
Yes it works fine now, thanks!


Main - General - Saving with the emulation paused, freezes the emulation in current master New reply

Page rendered in 0.018 seconds. (2048KB of memory used)
MySQL - queries: 27, rows: 90/90, time: 0.014 seconds.
[powered by Acmlm] Acmlmboard 2.064 (2018-07-20)
© 2005-2008 Acmlm, Xkeeper, blackhole89 et al.